22
90%
master: 90%

Ran 07 Jul 2019 08:48PM CUT

Files 14

Run time 0s

Badge

Embed ▾

Committed 07 Jul 2019 08:33PM CUT coverage: 94.263%. Remained the same

Job # rbx-3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset

Build Type

push

travis-ci

Committed by

sds

Commit Message

 Fix ChildProcess::Unix::Process#exited? method with leader processes

After sending TERM to a leader process, `::Process.waitpid2(_pid, ::Process::WNOHANG | ::Process::WUNTRACED)` appears to just return nil under ruby 2.6.

This causes process.stop to send TERM to the process, poll (unsuccessfully) for the exit status until the timeout is hit, then send KILL.

Run Details

838 of 889 relevant lines covered (94.26%)

39.23 hits per line

Source Files on job 451.22 (rbx-3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
65.81	lib/childprocess.rb	211 + 193	117 + 106	77 + 66	40 + 40	99.0 + 23
94.63	spec/spec_helper.rb	269 + 140	149 + 118	141 + 112	8 + 6	66.0 + 63
96.15	lib/childprocess/abstract_process.rb	189 + 181	52 + 47	50 + 45	2 + 2	114.0 - 6
99.59	spec/childprocess_spec.rb	443 + 433	241 + 234	240 + 234	1	11.0 + 10
100.0	lib/childprocess/unix/process.rb	85 - 127	49 - 27	49 - 14	0 - 13	144.0 + 143
100.0	spec/abstract_io_spec.rb	11 - 94	7 - 40	7 - 12	0 - 28	1.0
100.0	spec/io_spec.rb	227 + 168	124 + 117	124 + 118	0 - 1	1.0 - 2
100.0	spec/pid_behavior.rb	10 - 77	7 - 29	7 - 13	0 - 16	1.0
100.0	spec/platform_detection_spec.rb	82 + 66	51 + 41	51 + 41	0	11.0
100.0	lib/childprocess/abstract_io.rb	32 - 35	15 - 19	15 + 5	0 - 24	7.0 + 6

84.78
lib/
98.53
spec/

enkessler / childprocess / 451 / 22
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.22 (rbx-3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 451 / 22 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.22 (rbx-3, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 451 / 22
90%
master: 90%

README BADGES
x