12
90%
master: 90%

Ran 07 Jul 2019 08:41PM CUT

Files 18

Run time 1s

Badge

Embed ▾

Committed 07 Jul 2019 08:33PM CUT coverage: 83.726% (+0.5%) from 83.184%

Job # 2.6, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset

Build Type

push

travis-ci

Committed by

sds

Commit Message

 Fix ChildProcess::Unix::Process#exited? method with leader processes

After sending TERM to a leader process, `::Process.waitpid2(_pid, ::Process::WNOHANG | ::Process::WUNTRACED)` appears to just return nil under ruby 2.6.

This causes process.stop to send TERM to the process, poll (unsuccessfully) for the exit status until the timeout is hit, then send KILL.

Run Details

746 of 891 relevant lines covered (83.73%)

35.68 hits per line

Source Files on job 451.12 (2.6, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
9.09	spec/unix_spec.rb	57 + 41	33 + 22	3 - 7	30 + 29	1.0
15.38	lib/childprocess/unix/fork_exec_process.rb	78 + 76	39 + 38	6 + 5	33 + 33	1.0
21.43	spec/jruby_spec.rb	24 - 21	14 - 10	3 - 8	11 - 2	1.0
23.08	spec/windows_spec.rb	23 - 18	13 - 10	3 - 3	10 - 7	1.0
28.57	spec/pid_behavior.rb	12 - 3	7 - 1	2 - 5	5 + 4	1.0
68.93	lib/childprocess.rb	210 + 141	103 + 76	71 + 58	32 + 18	14.0 + 13
71.43	lib/childprocess/errors.rb	37 - 1	14 + 4	10	4 + 4	1.0
80.0	lib/childprocess/unix/io.rb	21 - 5	10 + 5	8 + 3	2 + 2	7.0 + 6
90.16	lib/childprocess/abstract_process.rb	192 + 165	61 + 51	55 + 50	6 + 1	24.0 + 23
92.65	lib/childprocess/unix/posix_spawn_process.rb	134 - 221	68 - 105	63 - 57	5 - 48	224.0 + 222

79.77
lib/
87.58
spec/

enkessler / childprocess / 451 / 12
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.12 (2.6, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 451 / 12 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.12 (2.6, CHILDPROCESS_POSIX_SPAWN=true CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 451 / 12
90%
master: 90%

README BADGES
x