2
66%
master: 65%

Ran 02 Jul 2019 03:32PM UTC

Files 6

Run time 1s

Badge

Embed ▾

Committed 02 Jul 2019 02:51PM UTC coverage: 66.124%. Remained the same

Job # 268.2

Build Type

Pull #51

travis-ci

Committed by

web-flow

Commit Message

s3: update region logic for ListBuckets method

The previous implementation was relying on 'GetBucketLocation' however
this seems flawed as the pointer could be `nil` (trigger panics), and
the returned result would not fully match the existing regions; as the
result of location are following:
https://github.com/aws/aws-sdk-go/blob/master/service/s3/api.go#L24385

So this would have worked only for a handful of cases. Using
GetBucketRegionWithClient should solve that, however it is not scoped to
any interface/struct, so it makes the testing more painful.

Pull Request Pull Request #51: s3: update region logic for ListBuckets method

Run Details

203 of 307 relevant lines covered (66.12%)

0.77 hits per line

cycloidio / raws / 268 / 2
66%
master: 65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 268.2

cycloidio / raws / 268 / 2 66% master: 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 268.2

cycloidio / raws / 268 / 2
66%
master: 65%

README BADGES
x