aiidateam / aiida_core / 6539 / 5
74%
develop: 74%

DEFAULT BRANCH: develop
Ran
Files 392
Run time 18s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.81% (+0.007%) from 67.803%
TEST_AIIDA_BACKEND=django TEST_TYPE="tests"

push

travis-ci

web-flow 
Fix potential inefficiency in `aiida.tools.data.cif` converters (#3098)

Recently, the `BackendNode` interface and implementation was changed
significantly with respect to attributes and extras. As a result, the
values on unstored nodes are not cleaned *until* the node is stored.
That means that unstored nodes can contain attributes and extras with
uncleaned values. For example an unstored `Dict` node can contained
stored `Float` nodes. This change becomes problematic in the
implementation of `_get_aiida_structure_pymatgen_inline` and
`_get_aiida_structure_ase_inline` of `aiida.tools.data.cif`. The
`parameters` keyword argument can be an unstored `Dict` node, if the
functions are run with `store_provenance=False`. Since it is unstored,
it can contain *stored* nodes for the values within them. For example,
the `site_tolerance` can be a stored `Float`. Since they are overloaded
native float objects, they can be passed to pymatgens `CifParser`
without it complaining. However, now whenever that class references the
value, since it is a stored node, the `ModelWrapper` will cause the
model instance to be refreshed from the database, which becomes
prohibitively expensive. Simply calling `clean_value` on the
`parameters` beforehand, will cause these nodes to be dereferenced into
their base values, which solves the issue.

21967 of 32395 relevant lines covered (67.81%)

0.68 hits per line

Source Files on job 6539.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")