5
94%
master: 94%

Ran 26 Jun 2019 09:33AM UTC

Files 26

Run time 3s

Badge

Embed ▾

Committed 26 Jun 2019 09:31AM UTC coverage: 93.068% (-0.05%) from 93.114%

Job # MONGODB=${MONGODB_3_4} PYMONGO=3.4.x

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Drop support for positional arguments when instantiating a document (#2103)

For example, if you had the following class:
```
class Person(Document):
    name = StringField()
    age = IntField()
```

You could instantiate an object of such class by doing one of the following:
1. `new_person = Person('Tom', 30)`
2. `new_person = Person('Tom', age=30)`
3. `new_person = Person(name='Tom', age=30)`

From now on, only option (3) is allowed.

Supporting positional arguments may sound like a reasonable idea in this
heavily simplified example, but in real life it's almost never what you want
(especially if you use inheritance in your document definitions) and it may
lead to ugly bugs. We should not rely on the *order* of fields to match a given
value to a given name.

This also helps us simplify the code e.g. by dropping the confusing (and
undocumented) `BaseDocument._auto_id_field` attribute.

Run Details

4914 of 5280 relevant lines covered (93.07%)

0.93 hits per line

MongoEngine / mongoengine / 2855 / 5
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2855.5 (MONGODB=${MONGODB_3_4} PYMONGO=3.4.x)

MongoEngine / mongoengine / 2855 / 5 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2855.5 (MONGODB=${MONGODB_3_4} PYMONGO=3.4.x)

MongoEngine / mongoengine / 2855 / 5
94%
master: 94%

README BADGES
x