kubeflow / pipelines / 3303 / 1

0%

master: 0%

push

travis-ci-com

Add a helper function to create tensorboard crd (#1237)

* Add a helper function to create a tensorboard crd.

* Add a helper function to create a tensorboard crd.

* Remove optional parameter "pretty".

* Reuse constants when possible

* createTensorboardInstance, getTensorboardInstance, waitForTensorboardInstance

* Revise getTensorboardHandler and createTensorboardHandler to use getTensorboardInstance
and createTensorboardInstance

* remove trailing spaces

* Fix comment

* Ajust paremeter values.

* stringfy error objects; change 'plural' to 'viewer'

* Change 'plural' to 'viewers'

* Use derived namespace (instead of hardcoded kubeflow) to create viewer
 CRD. Derive viewer CRD's name from log dir.

* Adjust local dns

* Add GCP credentials for viewer resource.

* Address pr reviews

* auto formatting

* 1. viewer controller propagates credentials when creating pod
2. set credentials in viewer crd

* Put credentials info in PodTemplateSpec

* Cleanup not-to-be-included changes.

* Empty line

* Formatting

* Remove a duplicate include

* add crypto-js dependency

* Add path prefix

* Update k8s-helper.ts

* (1) set viewer service port be 6006 (2) trailing / is required for tensorboard path

* Remove url address encoding

* Remove an accidental change

* Formatting

* Add comment and TODO

* Change 6006 back to 80

* Remove deprecated functions from k8shelper. Revise some comments.

* Use getNamespacedCustomobject

* Try to fix unit test for the tensorboard.tsx change

* Re-arrange func order

* Polish comments

* When there is no existing tensorboard, GetNamespacedCustomObject's promise is reject, and in case of that reject, use ''

1518 of 1701 branches covered (89.24%)

Branch coverage included in aggregate %.

2607 of 2741 relevant lines covered (95.11%)

60.47 hits per line