1
72%
master: 72%

Ran 20 Jun 2019 03:24PM UTC

Files 535

Run time 39s

Badge

Embed ▾

Committed 20 Jun 2019 03:24PM UTC coverage: 71.33% (-0.005%) from 71.335%

Job # 486.1

Build Type

push

jenkins

Committed by GitHub

Commit Message

[DLOG] Delete empty inprogress segment on recovery

This addresses an issue, whereby if a user is using getLastTxId() to
find the first txnid when starting to write, they will continue to be
able to write if the last segment written by the previous writer was
empty. If the last segment was empty, then the maxTxId would be higher
than the result of getLastTxId(). maxTxId is read from a znode, while
getLastTxId() reads the txid of the last persisted record. In the case
of an empty inprogress segment, the maxTxId znode was being updated
with the expected first transaction id of the segment.

This patch addresses the issue with the following changes:
1. The maxTxId znode is only updated when inprogress segment is
   completed, so it's value always refers to a transaction that
   exists.
2. On recovery, if the inprogress segment is empty, delete it. There
   was a TODO comment to do this already there.
3. When generating the sequence number, allow a potential sequence
   number which is equal to the current max sequence number, as this
   can be the case where recovery deleted an inprogress empty segment.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #2099 from ivankelly/txnid-issue

Coverage Stats

27196 of 38127 relevant lines covered (71.33%)

0.71 hits per line

apache / bookkeeper / 486 / 1
72%
master: 72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 486.1

apache / bookkeeper / 486 / 1 72% master: 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 486.1

apache / bookkeeper / 486 / 1
72%
master: 72%

README BADGES
x