mozilla / source-map / 558 / 2

88%

master: 89%

Pull #396

travis-ci

make the SourceMap node validation more precise and possibly more performant: check for the okay/good cases before checking the various error situations. Hence the first error check (with its extensive report message) has been moved down. The check has been duplicated for the 'generated' section of the mapping as that's another potential user app programmer error source.

The diff is a little large because I turned on `prettier` for all my branches for easier merging/diffing (once one has moved to a `prettier`-formatted codebase).

Extracted from SHA-1: 151593b34 * stricter validation for source and generated line/column: when they exist, they MUST be numbers. Related to https://github.com/mozilla/source-map/issues/385 (which is not fixed by this, mind you). For this patch I choose to stick with the exception being thrown as that better ensures code/mapping quality AFAIAC.

As all error validation checks are now in a single spot and within a single conditional chunk, source-map can choose to resolve by, for example, providing a source-map option which enables/disables these checks.

468 of 551 branches covered (84.94%)

Branch coverage included in aggregate %.

827 of 915 relevant lines covered (90.38%)

162.85 hits per line