wikimedia / parsoid / 2700 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/f77cdf056">html2wt: Tweak regexps: add D modifier if reqd + unescape \$

* Looked for preg_match instances in the html2wt code and added the
  D modifier for regexps using a trailing $ if there is no \s or \n
  before the $. For instances where it is clear that the string
  will not have a \n (tag names, parsoid-inserted attribute values
  for typeof or ids), I didn&#39;t add a D modifier.

  But, it can be argued that it is less cognitive overload to simply
  add the D modifier to all regexps that use a trailing $ since this
  is simply less error-prone and more robust. A discussion to be had
  and best practices updated if we want to go this way.

  Something for a followup across the entire codebase.

* Looks like js2php is using \$ in some scenarios. It is conservative
  about escaping $ in double-quoted stirngs. This is unnecessary if the
  character after the $ isn&#39;t a valid identifier character or open brace.
  I&#39;ve removed the backslash escape in a few places.

* 1 additional html2wt test is now passing with these fixes.

Bug: T213980
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/16ca03408">16ca03408</a>

Run Details

9541 of 12027 branches covered (79.33%)

14918 of 17646 relevant lines covered (84.54%)

29650.2 hits per line