1
26%
master: 44%

Ran 07 Jun 2019 03:50PM CUT

Files 16

Run time 1s

Badge

Embed ▾

Committed 07 Jun 2019 03:39PM CUT coverage: 26.097% (-4.2%) from 30.291%

Job # TRAVIS_PIPELINE=docker

Build Type

Pull #94

travis-ci

Committed by

web-flow

Commit Message

Fixing bugs related to Tenantconfig handling.

1: There was a nil pointer reference error in metacni during creation of DANM client
2: IsDynamicBackend incorrectly did not recognize ipvlan as such
3: Accidentally used shallow copy was changed to a (manual, sigh) deep copy when we save the original manifest during net, and conf validation
4: HostDevices list was not properly patched. When changed, the whole JSON list is now put together, and sent for replacement
5: When a host_device or devicepool is explicitly requested, but is not configured, we throw a validation error
6: hostDevices are now filtered, so DevicePools are not accidentally randomly allocated as host_device for a TenantNetwork
7: Mutating VLAN and VxLAN types for accidentally switched up due to wrong condition
8: NetworkIDs were not mutated into the networks because we haven't checked whether they even changed
9: NEtworkID pre-validation was accidentally removed from ClusterNetwork, not from TenantNetwork :)

DISCLAIMER: Freeing VNIs in TenantConfig does not work because K8s does not fill ANY Objects in DELETE requests!!!
Fortunetaly correction is merged, but we need to wait for 1.15.
Til then - no freeing of VNIs.

Pull Request Pull Request #94: DANM 4.0 EP4: Adding the TenantNetwork mutating code to the Webhook.

Run Details

541 of 2073 relevant lines covered (26.1%)

6.63 hits per line

Source Files on job 442.1 (TRAVIS_PIPELINE=docker)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	pkg/admit/confadmit.go	127	90	0	90	0.0
0.0	pkg/admit/netdel.go	43	29	0	29	0.0
0.0	pkg/admit/utils.go	124	87	0	87	0.0
0.0	pkg/confman/confman.go	115	87	0	87	0.0
0.0	pkg/danmep/ep.go	262 + 177	222 + 185	0	222 + 185	0.0
0.0	pkg/netcontrol/net.go	220 - 143	169 - 34	0	169 - 34	0.0
1.75	pkg/metacni/metacni.go	518 + 452	400 + 381	7 + 7	393 + 374	3.0 + 3
4.41	pkg/admit/validators.go	194	136	6	130	10.0
4.81	pkg/admit/netadmit.go	258	187	9	178	26.0
17.59	pkg/danmep/danmep.go	184 + 155	108 + 94	19 + 5	89 + 89	7.0 + 6

26.1
pkg/

nokia / danm / 442 / 1
26%
master: 44%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 442.1 (TRAVIS_PIPELINE=docker)

nokia / danm / 442 / 1 26% master: 44%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 442.1 (TRAVIS_PIPELINE=docker)

nokia / danm / 442 / 1
26%
master: 44%

README BADGES
x