salesforce / refocus / 9569 / 1

89%

master: 89%

push

travis-ci

Add publish tests for real-time events for subjects (#1180)

* Add publish tests for real-time events for subjects

Fix bugs uncovered by these new tests:
- do not publish an add event when creating a subject with isPublished=false
- when checking whether a subject's "isPublished" attribtue was changed. we were just looking at the current (new) value and the list of fields marked as changed by sequelize... but this causing problems for PUT operations... even if the PUT was NOT changing the isPublished attribute, if the field was included in the request body, then sequelize was including it in the list of changed fields. So I have updated the check to ALSO look at the old value only treat it as changed if the new value !== the old value
- when tags or absolutePath changes, we send a remove event then an add event so that filtering is correct - fix the remove event so that it is populated with the "old" values
- if a non-filtering attribute changes, we should be sending an update event (but we weren't)
- for bulk deletes, we were double-publishing - once from the db's afterDestroy and again from the bulkDeleteSubjects implementation, so remove the publish call from bulkDeleteSubjects and just let the db layer handle it

* Update subjects.js

2812 of 3601 branches covered (78.09%)

7620 of 8711 relevant lines covered (87.48%)

532.96 hits per line