22
90%
master: 90%

Ran 04 Jun 2019 07:15PM CUT

Files 15

Run time 1s

Badge

Embed ▾

Committed 04 Jun 2019 05:58PM CUT coverage: 87.995% (+0.1%) from 87.863%

Job # 2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset

Build Type

push

travis-ci

Committed by

sds

Commit Message

Fix ChildProcess::Unix::Process#wait method with leader processes

Issue #151 reported a problem where in the update from Ruby 2.5 to Ruby
2.6 some programs would block forever on a `Process.waitpid2` call.

Changing the call to pass in a positive PID instead of the negative PID
fixes the issue as it will call the `waitpid` system call right away
instead of delaying it for later.

See #151 for further discussion of the possible reasons for the
behavior.

Run Details

667 of 758 relevant lines covered (87.99%)

5.84 hits per line

Source Files on job 446.22 (2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
21.43	spec/jruby_spec.rb	24 - 158	14 - 87	3 - 83	11 - 4	1.0 - 354
23.08	spec/windows_spec.rb	23 - 290	13 - 128	3 - 66	10 - 62	1.0 - 2
52.5	lib/childprocess/unix/fork_exec_process.rb	78 - 73	40 - 61	21 - 75	19 + 14	19.0 + 18
62.86	lib/childprocess.rb	210 + 100	105 + 42	66 + 54	39 - 12	13.0 + 12
71.43	lib/childprocess/errors.rb	37 + 4	14 - 4	10 - 7	4 + 3	1.0
90.16	lib/childprocess/abstract_process.rb	192 + 123	61 + 18	55 + 14	6 + 4	25.0 + 24
94.44	lib/childprocess/abstract_io.rb	36 + 2	18 + 2	17 + 6	1 - 4	3.0 + 2
97.78	lib/childprocess/unix/process.rb	90 + 52	45 + 20	44 + 19	1 + 1	21.0 + 17
100.0	spec/childprocess_spec.rb	447 + 438	240 + 236	240 + 236	0	1.0
100.0	spec/io_spec.rb	228 - 194	124 - 82	124 - 44	0 - 38	1.0 - 399

76.51
lib/
95.43
spec/

enkessler / childprocess / 446 / 22
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 446.22 (2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 446 / 22 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 446.22 (2.2, CHILDPROCESS_POSIX_SPAWN=false CHILDPROCESS_UNSET=should-be-unset)

enkessler / childprocess / 446 / 22
90%
master: 90%

README BADGES
x