1
90%
master: 92%

Ran 03 Jun 2019 12:12AM UTC

Files 18

Run time 1s

Badge

Embed ▾

Committed 02 Jun 2019 11:59PM UTC coverage: 90.259% (+0.2%) from 90.094%

Job # 235.1

Build Type

Pull #87

travis-ci

Committed by

web-flow

Commit Message

Refactor parse_joins, pt.2: implicit/cross/natural joins

- reduce duplication in the handling of implicit/cross joins and make
  the flow of data slightly clearer by returning the `join` instead of
  pushing it and exiting early.

  (I wanted the block that currently returns `join` to return one of
  JoinOperator::* tags, so that `parse_table_factor` and the construction
  of the `Join` struct could happen after we've parsed the JOIN keywords,
  but that seems impossible.)

- move the check for the NATURAL keyword into the block that deals with 
  INNER/OUTER joins that support constraints (and thus can be preceded
  by "NATURAL")

- add a check for NATURAL not followed by a known join type with a test

- add more tests for NATURAL joins (we didn't have any), and fix
  whitespace bug in `to_string()` that was uncovered (we emitted an
  extra space: `foo NATURAL JOIN bar `)

Pull Request Pull Request #87: Refactor parse_joins

Coverage Stats

3345 of 3706 relevant lines covered (90.26%)

0.9 hits per line

andygrove / sqlparser-rs / 235 / 1
90%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 235.1

andygrove / sqlparser-rs / 235 / 1 90% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 235.1

andygrove / sqlparser-rs / 235 / 1
90%
master: 92%

README BADGES
x