• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

flyerhzm / bullet / 308 / 4
0%
master: 0%

Build:
DEFAULT BRANCH: master
Ran 12 Mar 2015 07:43PM UTC
Files 57
Run time 18s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Mar 2015 07:40PM UTC coverage: 68.393%. Remained the same
2.1.2, DB=sqlite, Gemfile.rails-3.2

Pull #213

travis-ci

anthuswilliams
don't execute query when running to_sql

in AR 4.1 and 4.2, to_sql calls find_with_associations
to attach relevant joins so that the produced SQL matches
the sql actually used when running the query. Bullet's
monkey-patch of find_with_associations calls the original
without a block so it actually passes the query to
the DB connection and runs it.

This commit simply branches the monkey-patch on
block_given? to make it consistent with AR's
definition of the same method. To wit, when
find_with_associations is called by a block, it
yields a new relation with the correct associations
joined and doesn't pass the query on to the DB.
Pull Request #213: don't execute query when running to_sql

1268 of 1854 relevant lines covered (68.39%)

8.61 hits per line

Source Files on job 308.4 (2.1.2, DB=sqlite, Gemfile.rails-3.2)
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 308
  • Travis Job 308.4
  • 048a83ff on github
  • Prev Job for 2.1.2, DB=sqlite, Gemfile.rails-3.2 on master (#307.4)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc