3
0%
master: 0%

Ran 12 Mar 2015 07:43PM UTC

Files 57

Run time 16s

Badge

Embed ▾

Committed 12 Mar 2015 07:40PM UTC coverage: 69.364%. Remained the same

Job # 2.1.2, DB=sqlite, Gemfile.rails-4.0

Build Type

Pull #213

travis-ci

Committed by

anthuswilliams

Commit Message

don't execute query when running to_sql

in AR 4.1 and 4.2, to_sql calls find_with_associations
to attach relevant joins so that the produced SQL matches
the sql actually used when running the query. Bullet's
monkey-patch of find_with_associations calls the original
without a block so it actually passes the query to
the DB connection and runs it.

This commit simply branches the monkey-patch on
block_given? to make it consistent with AR's
definition of the same method. To wit, when
find_with_associations is called by a block, it
yields a new relation with the correct associations
joined and doesn't pass the query on to the DB.

Pull Request Pull Request #213: don't execute query when running to_sql

Coverage Stats

1286 of 1854 relevant lines covered (69.36%)

8.42 hits per line

flyerhzm / bullet / 308 / 3
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 308.3 (2.1.2, DB=sqlite, Gemfile.rails-4.0)

flyerhzm / bullet / 308 / 3 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 308.3 (2.1.2, DB=sqlite, Gemfile.rails-4.0)

flyerhzm / bullet / 308 / 3
0%
master: 0%

README BADGES
x