apel / ssm / 439 / 2

40%

dev: 40%

push

travis-ci

OpenSSL checkend fix (#97)

- Add missing seconds argument after '-checkend' as it should
be followed by a number that defines how many seconds
ahead openssl x509 should check for cert expiry, otherwise later
versions of OpenSSL raise syntax errors (treating next arg as the
number). Set it to a day as certs should really be replaced before that
considering the amount of time it can take a message to traverse the
messaging system.
- Update error messages to match verify_cert_date as
verify_cert_date has been updated to check that the cert won't expire
within the next day, the error messages should explain this if there's a
verification failure
- Increase the temp cert validity to 2 days so that it's comfortably
longer than the period that verify_cert_date checks for (1 day).
- Update expected error for expired cert test to match updated function.

88 of 243 branches covered (36.21%)

Branch coverage included in aggregate %.

365 of 893 relevant lines covered (40.87%)

0.41 hits per line