6
97%
master: 97%

Ran 11 May 2019 07:27PM UTC

Files 20

Run time 1s

Badge

Embed ▾

Committed 11 May 2019 07:20PM UTC coverage: 94.244% (+0.07%) from 94.173%

Job # REQUIREMENTS=release

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

bugfix(datastore) Fix get_user for various DBs (#73)

DB drivers vary in how strict they are. For example
postgres+pyscopg2 throws errors if you attempt to lower(<integer>) or
compare a string field with an integer field.
Furthermore, when pyscopg2 throws an internal error like that, it
aborts the transaction - so you can't just try another query.

To solve this - in get_user we check for compatibility of types using
metadata that the ORM provides. This isn't trying to be completely
general - just looking at numeric and non-numeric types - on the
presumption that we would have unique user attributes on things like
dates, boolean, etc!.

To enable testing, added an option to pytest to specify a real DB
url to replace the default sqlite. This required a bit of refactoring
and realized that we really shouldn't be passing in fixtures to
the datastore() fixture since that meant all 5 datastores would be
instantiated EVERY time - which for a real DB was a performance issue.

With this addition - tested Sqlalchemy, peewee, pony with sqlite,
postgres, mysql.

Run Details

1408 of 1494 relevant lines covered (94.24%)

0.94 hits per line

jwag956 / flask-security / 160 / 6
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 160.6 (REQUIREMENTS=release)

jwag956 / flask-security / 160 / 6 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 160.6 (REQUIREMENTS=release)

jwag956 / flask-security / 160 / 6
97%
master: 97%

README BADGES
x