1
100%
master: 100%

Ran 07 May 2019 10:44AM UTC

Files 32

Run time 3min

Badge

Embed ▾

Committed 07 May 2019 10:41AM UTC coverage: 100.0%. Remained the same

Job # 2.3.8

Build Type

Pull #121

travis-ci

Committed by

web-flow

Commit Message

Make it clear when error comes from mocking in tests

This is a small quality of life enhancement when debugging test
failures. When you comment out the catch-all `rescue` in the production
code of Prometheus::Middleware::Collector, you see a `NoMethodError`
with no stack or message attached.

Initially, this is pretty confusing, and you may think it was the reason
for your tests failing! In fact, it's to test the catch-all rescue.

This commit makes it really explicit that the error is deliberately
coming from the tests.

Signed-off-by: Chris Sinjakli <chris@gocardless.com>

Pull Request Pull Request #121: Remove support for flexible labels in collector middleware

Run Details

1383 of 1383 relevant lines covered (100.0%)

14.07 hits per line

prometheus / client_ruby / 367 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 367.1 (2.3.8)

prometheus / client_ruby / 367 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 367.1 (2.3.8)

prometheus / client_ruby / 367 / 1
100%
master: 100%

README BADGES
x