3
98%
master: 98%

Ran 01 May 2019 05:12AM UTC

Files 242

Run time 11s

Badge

Embed ▾

Committed 01 May 2019 05:06AM UTC coverage: 97.951%. Remained the same

Job # NAME="unix coverage build and tests"

Build Type

push

travis-ci

Committed by Damien George

Commit Message

unix/gcollect: Make sure stack/regs get captured properly for GC.

When building with link time optimization enabled it is possible both
gc_collect() and gc_collect_regs_and_stack() get inlined into gc_alloc()
which can result in the regs variable being pushed on the stack earlier
than some of the registers. Depending on the calling convention, those
registers might however contain pointers to blocks which have just been
allocated in the caller of gc_alloc(). Then those pointers end up higher on
the stack than regs, aren't marked by gc_collect_root() and hence get
sweeped, even though they're still in use.

As reported in #4652 this happened for in 32-bit msvc release builds:
mp_lexer_new() does two consecutive allocations and the latter triggered a
gc_collect() which would sweep the memory of the first allocation again.

Coverage Stats

18401 of 18786 relevant lines covered (97.95%)

364703.19 hits per line

micropython / micropython / 10573 / 3
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10573.3 (NAME="unix coverage build and tests")

micropython / micropython / 10573 / 3 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 10573.3 (NAME="unix coverage build and tests")

micropython / micropython / 10573 / 3
98%
master: 98%

README BADGES
x