4
83%
master: 83%

Ran 23 Apr 2019 11:22AM UTC

Files 17

Run time 1s

Badge

Embed ▾

Committed 23 Apr 2019 11:20AM UTC coverage: 79.832% (+0.02%) from 79.814%

Job # 1652.4

Build Type

push

travis-ci

Committed by

julienschmidt

Commit Message

connection: interpolate uint64 parameters (#955)

PR #838 introduced a fix for the driver's custom Value Converter that
stopped emitting large uint64 `driver.Value`s as a string. Instead, now
_all_ uint{8,16,32,64} values passed to the driver are returned as
uint64, and `packets.c` now explicitly handles `driver.Value` instances
that are uint64.

However, the update in `packets.c` only applies when sending
`driver.Value` arguments to the server. When a connection is set up
using `InterpolateParams = true` and query interpolation happens inside
of the driver, the `(*mysqlConn) interpolateParams` does **not** handle
uint64 values (which, again, are now passed by `database/sql` because
we've updated our value converter to generate them).

Because of this, any `DB.Query` operations which have an uint argument
(regardless of its size!!) will force the driver to return
`driver.ErrSkip`, disabling client interpolation for such queries.

We can fix this by updating `interpolateParams` like we previously
updated `writeExecutePacket`.

Run Details

2751 of 3446 relevant lines covered (79.83%)

56432.35 hits per line

go-sql-driver / mysql / 1652 / 4
83%
master: 83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1652.4

go-sql-driver / mysql / 1652 / 4 83% master: 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1652.4

go-sql-driver / mysql / 1652 / 4
83%
master: 83%

README BADGES
x