1
89%
master: 94%

Ran 22 Apr 2019 08:26PM CUT

Files 210

Run time 12s

Badge

Embed ▾

Committed 22 Apr 2019 08:15PM CUT coverage: 89.043%. Remained the same

Job # 2242.1

Build Type

Pull #853

travis-ci

Committed by

web-flow

Commit Message

Switch from 'ps' to 'kill -0' to check on children processes

Using 'ps' to check for process termination can sometimes produce false-negatives.
I.e. returning with non-zero exit code when the process is actually still running.
This situation can lead Genie to mark a job as failed when it was actually still running.

Switch to using 'kill -0' as per POSIX recommendation.

I.e. returning with non-zero exit code when the process is actually still running.
This situation can lead Genie to mark a job as failed when it was actually still running.

Switch to using  as per POSIX recommendation.
(this can still produce false negatives, such as when permissions are lacking, or when kill fails to launch due to resource exhaustion)

Pull Request Pull Request #853: Switch from 'ps' to 'kill -0' to check on children processes

Run Details

6420 of 7210 relevant lines covered (89.04%)

0.89 hits per line

Source Files on job 2242.1

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	...lient/interceptors/UserAgentInsertInterceptor.java	70 + 36	13 - 8	0 - 21	13 + 13	0.0 - 1.0
0.0	.../main/java/com/netflix/genie/client/JobClient.java	574 + 521	103 + 85	0 - 18	103 + 103	0.0 - 3
0.0	...ava/com/netflix/genie/web/configs/RedisConfig.java	67 + 48	5	0 - 5	5 + 5	0.0 - 1.0
0.0	...enie/client/configs/GenieNetworkConfiguration.java	57 - 62	7 - 31	0 - 38	7 + 7	0.0 - 6
0.0	...com/netflix/genie/web/configs/aws/AwsS3Config.java	123 - 69	14 + 14	0	14 + 14	0.0
14.29	...m/netflix/genie/web/aspect/SystemArchitecture.java	79 + 20	7 - 18	1 - 24	6 + 6	1.0 - 8
38.46	...ecurity/oauth2/impl/OAuth2SecurityInterceptor.java	79 + 19	13	5 - 7	8 + 7	1.0 - 14
45.45	...2/pingfederate/PingFederateSecurityConditions.java	87 - 610	11 - 465	5 - 467	6 + 2	1.0
50.0	...-war/src/main/java/com/netflix/genie/GenieWar.java	58 + 24	4 - 17	2 - 19	2 + 2	1.0
50.0	...netflix/genie/web/security/SecurityConditions.java	58 + 9	6	3 - 3	3 + 3	1.0 - 9

58.18
genie-client/
97.5
genie-common/
94.37
genie-core/
66.67
genie-test/
50.0
genie-war/
88.1
genie-web/

Netflix / genie / 2242 / 1
89%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2242.1

Netflix / genie / 2242 / 1 89% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2242.1

Netflix / genie / 2242 / 1
89%
master: 94%

README BADGES
x