2
48%
master: 51%

Ran 20 Apr 2019 05:33AM UTC

Files 1340

Run time 59s

Badge

Embed ▾

Committed 20 Apr 2019 05:24AM UTC coverage: 47.028% (+0.01%) from 47.016%

Job # 1504.2

Build Type

push

travis-ci

Committed by

yasserzamani

Commit Message

Proposed fix for WW-5029 for the 2.5.x branch (#347)

* Proposed fix for WW-5029 for the 2.5.x branch:
- NOTE: If the PR is accepted please credit Maxime Clement for this change as they found
        the issue, identified the probable cause/related details and opened the JIRA.
- Updated XWorkConfigurationProvider buildAllowedMethods(), loadGlobalAllowedMethods() so that
  they now handle situations when a SAX parser produces multiple elements to represent the tag
  body value.
- No changes to unit tests.

* Update commit to fix weakness identified by Maxime Clement:
- Implementation should now properly concatenate the node children values together (as a single unified string)
  in both buildAllowedMethods(), loadGlobalAllowedMethods() - before generating the method Set to be added.
- Made some eligible variables final.

* Update commit to provide new unit tests:
- Added unit tests to confirm the fixes for buildAllowedMethods(), loadGlobalAllowedMethods()
- Added Mock DOM classes sufficient for these tests.
- Added unit tests to cover buildResults() and loadGlobalResults().

Run Details

27158 of 57748 relevant lines covered (47.03%)

12190.18 hits per line

apache / struts / 1504 / 2
48%
master: 51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1504.2

apache / struts / 1504 / 2 48% master: 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1504.2

apache / struts / 1504 / 2
48%
master: 51%

README BADGES
x