8
95%
master: 95%

Ran 17 Apr 2019 09:47AM UTC

Files 22

Run time 1s

Badge

Embed ▾

Committed 17 Apr 2019 09:45AM UTC coverage: 94.794% (+0.7%) from 94.134%

Job # 1319.8

Build Type

Pull #713

travis-ci

Committed by

web-flow

Commit Message

Add knob SPLIT_ALL_TOP_LEVEL_COMMA_SEPARATED_VALUES (#1)

Add knob SPLIT_ALL_TOP_LEVEL_COMMA_SEPARATED_VALUES

The existing knob SPLIT_ALL_COMMA_SEPARATED_VALUES is overly aggresive in that, if an argument list (or, more generally, a container) needs splitting, then all subexpressions will be split as well. For instance, in
```
abcdef(aReallyLongThing, b=(c,d))
```
if the line needs splitting because of `aReallyLongThing`, then it will produce
```
abcdef(
    aReallyLongThing,
    b=(c,
       d))
```
I've seen terrible things like
```
   argument: [Int,
              Int]
```
in function definitions with many arguments (even if the second `Int` fits in the line).

The new knob checks if a container (argument list, list literal, etc) fits in a line and avoids breaking if so, producing
```
abcdef(
    aReallyLongThing,
    b=(c, d))
```
which makes more sense (to me at least).

See https://github.com/prodo-ai/plz/pull/248 for an example of a codebase reformatted with the new knob (plus  `split_before_first_argument`). Nice, isn't it?

Pull Request Pull Request #713: Add knob SPLIT_ALL_TOP_LEVEL_COMMA_SEPARATED_VALUES

Coverage Stats

3077 of 3246 relevant lines covered (94.79%)

0.95 hits per line

google / yapf / 1319 / 8
95%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1319.8

google / yapf / 1319 / 8 95% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1319.8

google / yapf / 1319 / 8
95%
master: 95%

README BADGES
x