1
8%
master: 8%

Ran 16 Apr 2019 06:10PM UTC

Files 1

Run time 0s

Badge

Embed ▾

Committed 15 Apr 2019 05:53PM UTC coverage: 0.0%. Remained the same

Job # GO111MODULE=on

Build Type

cron

travis-ci

Committed by

jsha

Commit Message

fix dataraces, add -race install, add load-gen. (#232)

The `Authz()` method of the WFE was racey. First because it didn't lock the authorizations and orders it was working with. Second because the handling of displaying authorization challenges was working with `acme.Challenge` objects owned by `core.Challenge`'s that should have been locked for reading but were not. This mean the VA would datarace with the WFE when updating a validated challenge status.

To prevent future occurrences `travis.yml` is updated to install Pebble with the race detector enabled, and to run Pebble such that it will exit non-zero if a race is detected.

Since `Chisel2.py` is single threaded the Boulder `load-generator` is used for a short duration to drive concurrent request traffic. In practice before fixing the dataraces I found this would crash Pebble <30s.

Resolves https://github.com/letsencrypt/pebble/issues/230
Resolves https://github.com/letsencrypt/pebble/issues/228

Run Details

0 of 53 relevant lines covered (0.0%)

0.0 hits per line

letsencrypt / pebble / 1216 / 1
8%
master: 8%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1216.1 (GO111MODULE=on)

letsencrypt / pebble / 1216 / 1 8% master: 8%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1216.1 (GO111MODULE=on)

letsencrypt / pebble / 1216 / 1
8%
master: 8%

README BADGES
x