wikimedia / restbase / 884 / 2

Ran 04 Mar 2015 02:24AM UTC

Files 9

Run time 8s

Badge

Embed ▾

Committed 04 Mar 2015 02:22AM UTC coverage: 86.464% (-2.2%) from 88.628%

Job # 884.2

Build Type

Pull #205

travis-ci

Committed by

gwicke

Commit Message

Don't swallow & generate content for non-404 errors

The unconditional catch handler in parsoid.js triggered content generation on
*any* errors, not just 404s. This led to a large number of revisions to be
stored on some pages I was using for benchmarking.

It also covered up a bug in the handling of requests for 'latest' revisions.
The frontend code (and a test) was creating internal requests with 'latest' as
the revision, but the revision parsing code in key_rev_value did not consider
that a valid revision. Combined with the earlier bug this meant that each
request for an existing version was causing a new revision to be parsed &
saved.

This patch solves both problems by

- only generating content on 404, and re-raising any other errors, and

- dropping the `/latest` pseudo-revision in favor of a straight request for
  the title.

Pull Request Pull Request #205: Cassandra driver v2 fixes / tweaks

Run Details

741 of 857 relevant lines covered (86.46%)

36.13 hits per line

wikimedia / restbase / 884 / 2

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 884.2

wikimedia / restbase / 884 / 2

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 884.2

README BADGES
x