3
86%
master: 92%

Ran 04 Mar 2015 02:15AM UTC

Files 9

Run time 15s

Badge

Embed ▾

Committed 04 Mar 2015 02:09AM UTC coverage: 86.464% (-0.5%) from 86.987%

Job # 264.3

Build Type

push

travis-ci

Committed by

gwicke

Commit Message

Don't swallow & generate content for non-404 errors

The unconditional catch handler in parsoid.js triggered content generation on
*any* errors, not just 404s. This led to a large number of revisions to be
stored on some pages I was using for benchmarking.

It also covered up a bug in the handling of requests for 'latest' revisions.
The frontend code (and a test) was creating internal requests with 'latest' as
the revision, but the revision parsing code in key_rev_value did not consider
that a valid revision. Combined with the earlier bug this meant that each
request for an existing version was causing a new revision to be parsed &
saved.

This patch solves both problems by

- only generating content on 404, and re-raising any other errors, and

- dropping the `/latest` pseudo-revision in favor of a straight request for
  the title.

Coverage Stats

741 of 857 relevant lines covered (86.46%)

36.13 hits per line

gwicke / restbase / 264 / 3
86%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 264.3

gwicke / restbase / 264 / 3 86% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 264.3

gwicke / restbase / 264 / 3
86%
master: 92%

README BADGES
x