Ran
|
Files
70
|
Run time
8s
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
<a href="https://github.com/wikimedia/parsoid/commit/7608aeabd">Deal with chameleon nodes that change output based on surroundings * Normally, selser does not look at edit flags on the surrounding nodes to determine if the wikitext for the current node can be extracted from the original wikitext. However, this assumption breaks down for <td>/<th> nodes. For example, the second cell in a table row emitted as "||" would have to change its output to "|" if the first cell is deleted. Similarly for <th> nodes. This patch fixes selser to deal with this. * In addition, tag handlers should also ignore data-parsoid flags (stx and startTagSrc properties) for such table cells in some scenarios. * Also fixed long-standing bugs in before/after newline constraints for <td>/<th> cells which incidentally is what triggered the issue. Without these bugs, the other issues above would have remained hidden till a more subtle test case popped up. * Also had to fix up use of source separators to deal with this same issue to force a newline separator where required. * Added a new manual edit test case for non-selser serialization. A manual edit test case for selser serialization requires T72722 to be implemented, but a newly passing selser test shows that the code is working in some cases. Bug: T85782 Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/f78aa9cbf">f78aa9cbf</a>
9801 of 11658 relevant lines covered (84.07%)
22649.62 hits per line
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|