4
93%
master: 93%

Ran 30 Mar 2019 12:41PM UTC

Files 23

Run time 1s

Badge

Embed ▾

Committed 30 Mar 2019 12:18PM UTC coverage: 86.986% (+0.05%) from 86.934%

Job # 2074.4

Build Type

push

travis-ci-com

Committed by

BurntSushi

Commit Message

exec: add Aho-Corasick optimization

Finally, if a regex is just `foo|bar|baz|...|quux`, we will now use plain
old Aho-Corasick. The reason why we weren't doing this before is because
Aho-Corasick didn't support proper leftmost-first match semantics. But
since aho-corasick 0.7, it does, so we can now use it as a drop-in
replacement.

This basically fixes a pretty bad performance bug in a really common case,
but it is otherwise really hacked. First of all, this only happens when a
regex is literally `foo|bar|...|baz`. Even something like
`foo|b(a)r|...|baz` will prevent this optimization from happening, which
is a little silly. Second of all, this optimization only kicks in after
we've compiled the full pattern, which adds quite a bit of overhead. Fixing
this isn't trivial, since we may need the compiled program to resolve
capturing groups. The way to do this is probably to specialize compilation
for certain types of expressions. Maybe.

Anyway, we hack this in for now, and punt on further improvements until
we can really re-think how this should all work.

Run Details

3790 of 4357 relevant lines covered (86.99%)

0.87 hits per line

rust-lang / regex / 2074 / 4
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2074.4

rust-lang / regex / 2074 / 4 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2074.4

rust-lang / regex / 2074 / 4
93%
master: 93%

README BADGES
x