3
31%
main: 48%

Ran 28 Mar 2019 01:31PM UTC

Files 2417

Run time 4min

Badge

Embed ▾

Committed 28 Mar 2019 01:18PM UTC coverage: 24.768%. Remained the same

Job # MATRIX_EVAL="BUILD_TARGET=coverage_build && CC=gcc-6 && CXX=g++-6"

Build Type

push

travis-ci

Committed by

JonasVautherin

Commit Message

mission: fix mission upload cancel crash

This fixes a crash that happened when a mission upload was cancelled.
What happened is that the mission result callback ended up being called
twice on upload after a cancellation.

The reason for the two callback calls are, I believe, as follows:
- The autopilot is still in upload mode. Therefore, it will continue to
  send mission items continuing where we sent cancel. This means we will
  continue happily uploading from there and eventually report SUCCESS.
- However, since the autopilot is still in upload mode, it doesn not
  acknowledge our message indicating the count of the mission items.
  We receive this nack and report an error.

The fix for now is to abort immediately if we receive a nack.

The proper fix is for the mission plugin as well as the PX4 side to
implement mission cancelling using MAV_MISSION_OPERATION_CANCELLED to
avoid busy states like this.

Run Details

2193 of 8854 relevant lines covered (24.77%)

1679.59 hits per line

mavlink / MAVSDK / 3135 / 3
31%
main: 48%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3135.3 (MATRIX_EVAL="BUILD_TARGET=coverage_build && CC=gcc-6 && CXX=g++-6")

mavlink / MAVSDK / 3135 / 3 31% main: 48%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3135.3 (MATRIX_EVAL="BUILD_TARGET=coverage_build && CC=gcc-6 && CXX=g++-6")

mavlink / MAVSDK / 3135 / 3
31%
main: 48%

README BADGES
x