thriftrw / thriftrw-python / 705 / 6

74%

master: 92%

Pull #156

travis-ci

test_binary: Appease flake8 type hints

Newer versions of flake8 treat comments like the following as type
hints.

    # type:1 = FOO

Obviously, these are not valid type hints and cause issues with the
linter.

    tests/test_runtime.py:53:41: F723 syntax error in type comment '1 = ONEWAY'
    tests/protocol/test_binary.py:187:22: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:195:25: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:199:25: F723 syntax error in type comment '1 = list'
    tests/protocol/test_binary.py:203:37: F723 syntax error in type comment '1 = binary'
    tests/protocol/test_binary.py:234:22: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:238:34: F723 syntax error in type comment '1 = i32'
    tests/protocol/test_binary.py:246:22: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:250:34: F723 syntax error in type comment '1 = i32'
    tests/protocol/test_binary.py:361:20: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:369:20: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:377:26: F723 syntax error in type comment '1 = bool'
    tests/protocol/test_binary.py:386:26: F723 syntax error in type comment '1 = i16'
    tests/protocol/test_binary.py:395:26: F723 syntax error in type comment '1 = bool'

This change avoids using `type:` in comments in the relevant files.

155 of 162 branches covered (95.68%)

2196 of 2951 relevant lines covered (74.42%)

0.74 hits per line