proftpd / proftpd / 3625 / 1

Ran 25 Mar 2019 07:23PM UTC

Files 44

Run time 6s

Badge

Embed ▾

Committed 25 Mar 2019 07:17PM UTC coverage: 82.394% (-0.05%) from 82.446%

Job # PACKAGE_VERSION=1.3.7rc1

Build Type

Pull #787

travis-ci

Committed by

web-flow

Commit Message

- proftpd should not rely fsio I/O is instant

one of our customers hit this glitch on back up server,
which serves files from SAM-QFS [1] volume. The I/O on
such FS can take up to several seconds. This typically
happens when file must be retrieved from tape.

In this case the FSIO read(2) operation fails with
EINTR error. The EINTR failure is mishandled further:
instead of reporting error to remote client, server
sends file with 0 size.

The patch also makes the write(2) more robust. We did
not hit such issue, but I believe similar failures
might happen when received files are written to
NFS file systems.

the issue got uncovered during upgrade of 1.3.5b
to 1.3.6. Unlike 1.3.5b the new 1.3.6 guarantees
a minimum alarm(2) interval to be a 5sec.

[1] https://en.wikipedia.org/wiki/QFS

Pull Request Pull Request #787: - proftpd should not rely fsio I/O is instant

Run Details

17465 of 21197 relevant lines covered (82.39%)

262.54 hits per line

proftpd / proftpd / 3625 / 1

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3625.1 (PACKAGE_VERSION=1.3.7rc1)

proftpd / proftpd / 3625 / 1

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3625.1 (PACKAGE_VERSION=1.3.7rc1)

README BADGES
x