1
92%
master: 92%

Ran 25 Mar 2019 03:28PM UTC

Files 101

Run time 10s

Badge

Embed ▾

Committed 25 Mar 2019 03:24PM UTC coverage: 85.311% (+1.4%) from 83.957%

Job # 491.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[#113] Logic/command: fix bug in `requirement_add` (#112)

The implementation of the `requirement_add` command has a bug where no 
more than one module code can be added to a requirement category.

The bug was caused by not creating a new `Set<Code>` variable whenever a
module code is added to a requirement category.

To fix this bug, we create a new `Set<Code>` containing both the 
existing module codes and the module code to be added. We also update 
`RequirementAddCommandParser` to pass the only data parsed instead of 
creating a new `RequirementCategory` instance.

Let's fix the bug and close issue #113 using the methods described above
and cascade the changes to the affected classes. To prevent further 
regression bugs, let's also add in additional unit tests to ensure the 
desired behavior of the `requirement_add` command.

  [1/6] requirement: update logic of new command and checks
  [2/6] Update to files to reference updated methods
  [3/6] RequirementAddCommand: update methods and to receive data parsed
  [4/6] AddCommandTest: update to reference updated methods
  [5/6] test: update on test data generated
  [6/6] RequirementAddCommandTest: update to add in new test cases

Run Details

1934 of 2267 relevant lines covered (85.31%)

0.85 hits per line

CS2113-AY1819S2-T09-1 / main / 491 / 1
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 491.1

CS2113-AY1819S2-T09-1 / main / 491 / 1 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 491.1

CS2113-AY1819S2-T09-1 / main / 491 / 1
92%
master: 92%

README BADGES
x