pions / webrtc / 2630 / 1

Ran 22 Mar 2019 08:17PM UTC

Files 61

Run time 3s

Badge

Embed ▾

Committed 22 Mar 2019 08:13PM UTC coverage: 81.411% (+0.03%) from 81.386%

Job # GO111MODULE=on

Build Type

Pull #541

travis-ci

Committed by

web-flow

Commit Message

Optimize ice.Agent.getBestPair()

This function should be trivial but profiles show it taking 3-5% of my
application's CPU time. The problem is the constant creation of a
channel for message passing. This function is called by srtp.WriteRTP
for each packet, so it adds up.

My fix was to create a `runInner` function that utilizies a mutex. I
wanted to convert all `run` functions to `runInner` but the code
occasionally deadlocks in unit tests. The package is definitely a
candidate for a rewrite.

```
name           old time/op    new time/op    delta
GetBestPair-8     915ns ± 3%      80ns ± 4%  -91.23%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
GetBestPair-8      128B ± 0%       16B ± 0%  -87.50%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
GetBestPair-8      3.00 ± 0%      1.00 ± 0%  -66.67%  (p=0.008 n=5+5)
```

Pull Request Pull Request #541: Optimize ice.Agent.getBestPair()

Run Details

4086 of 5019 relevant lines covered (81.41%)

53.68 hits per line

pions / webrtc / 2630 / 1

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2630.1 (GO111MODULE=on)

pions / webrtc / 2630 / 1

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2630.1 (GO111MODULE=on)

README BADGES
x