wikimedia / parsoid / 2394 / 1

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

Make ListHandler pass phan

Phan really didn't like the ad-hoc "use an array for list frame objects"
style. Although I could have annotated each place it complained, or
fallen back on some `array<string,mixed>` type for the ListFrame, it
seemed better just to create a proper class.  Leads to more readable
code and more accurate phan checks.

I also made the $bullet_chars_map static while I was at it.  PHP 7.2
lets you just initialize this statically, saving a bit of extra
work.

Change-Id: If4244406d

Run Details

9553 of 12024 branches covered (79.45%)

14868 of 17609 relevant lines covered (84.43%)

28726.79 hits per line