wikimedia / parsoid / 2385 / 2

85%

master: 85%

Build Type

push

travis-ci

Committed by jenkins-bot

Commit Message

<a href="https://github.com/wikimedia/parsoid/commit/0806a23ff">Let fosterable nodes remain unfostered across serialization boundaries

* This patch adds new options to:
  - ContentUtils.ppToXML and XMLSerializer (while serializing the
    DOM) to tunnel content in fosterable positions via a data-fostered
    attribute on the parent node.

    This moves the fosterable content into the data-fostered attribute
    and replaces it with an empty placeholder comment.

    This is the tunnelFosteredContent option.

    Code is implemented on both the JS &amp; PHP sides.

  - ContentUtils.ppToDOM (while parsing HTML to DOM) to reinsert
    tunneled fosterable content back into the fosterable positions
    where they were originally found.

    This is the reinsertFosteredContent option.

    Code is implemented on both the JS &amp; PHP sides.

* Updated PHPDomTransform.js and runDOMTransform.php to use these new
  options while serializing DOM / parsing HTML to DOM.

* bin/parserTests.js --wt2html now runs to completion with
  computeDSR pass running on the PHP side.

  * Two previously failing tests changed their blacklisted output.

    - One is a true failure in the ComputeDSR pass because of an
      incomplete port of WTUtils::decodedCommentLength. As a result,
      the DSR value for one of the nodes is computed as [-10,0,0,0]
      which doesn&#39;t make sense. This will be fixed in a separate commit.

    - Another is a failure related to handling \r (and potentially
      other wikitext-illegal characters) in Parsoid. See T106578.
      This will be dealt with separately.

* Update bin/runDOMTransform.php to remove the HTML inputfile from
  disk on successful execution. This removes cluttering disk with
  temporary files.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/1e9b56ebe">1e9b56ebe</a>

Run Details

9551 of 12030 branches covered (79.39%)

14862 of 17628 relevant lines covered (84.31%)

28634.13 hits per line