17
51%
master: 47%

Ran 19 Mar 2019 01:46PM UTC

Files 2

Run time 0s

Badge

Embed ▾

Committed 19 Mar 2019 01:40PM UTC coverage: 51.396% (-0.1%) from 51.538%

Job # COVERAGE="--enable-coverage" EXTRA="libldap2-dev libykpers-1-dev libnet-ldap-server-perl lcov"

Build Type

Pull #188

travis-ci

Committed by

web-flow

Commit Message

Fix pam_get_data stack overwrite by saving a heap pointer instead

The previous code was using a trick of saving the actual retval value
as the "pointer". The problem with that was when pam_get_data copied
it out it treated it as a void* which is 8 byte on 64 bit operating
system which meant it copied 8 byte to a 4 byte location and overwrote
the stack with 4 bytes.

The fix is using a heap pointer instead, influenced by the official
code in https://github.com/linux-pam/linux-pam/blob/master/modules/pam_unix/pam_unix_auth.c

With feedback from pedro martelletto, thanks.

Pull Request Pull Request #188: Fix pam_get_data stack overwrite by saving a heap pointer instead

Run Details

405 of 788 relevant lines covered (51.4%)

15.38 hits per line

Yubico / yubico-pam / 355 / 17
51%
master: 47%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 355.17 (COVERAGE="--enable-coverage" EXTRA="libldap2-dev libykpers-1-dev libnet-ldap-server-perl lcov")

Yubico / yubico-pam / 355 / 17 51% master: 47%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 355.17 (COVERAGE="--enable-coverage" EXTRA="libldap2-dev libykpers-1-dev libnet-ldap-server-perl lcov")

Yubico / yubico-pam / 355 / 17
51%
master: 47%

README BADGES
x