1
92%
master: 92%

Ran 18 Mar 2019 06:37AM UTC

Files 101

Run time 4s

Badge

Embed ▾

Committed 18 Mar 2019 06:33AM UTC coverage: 83.107% (+0.06%) from 83.043%

Job # 352.1

Build Type

push

travis-ci

Committed by

lycjackie

Commit Message

Model: update `Credits#VALIDATION_REGEX` (#83)

`Credits#VALIDATION_REGEX` accepts at least 3 digits. However, this
constraint is too strict, and in addition, also assumes that there are
at least 3 digits supplied.

Consider the following logically valid `Credits`:

    0 Credits - entered as 000 (00000....0 is accepted too)
    4 Credits - entered as 005 (00000....4 is accepted too)
   12 Credits - entered as 012 (00000...12 is accepted too)
  150 Credits - entered as 150 (00000..150 is accepted too)

This makes adding / editing `Credits` extremely unintuitive for users.
We should instead treat the following `Credits`:

    0 Credits - accepted when entered exactly as: 0
    4 Credits - accepted when entered exactly as: 4
   12 Credits - accepted when entered exactly as: 12
  150 Credits - accepted when entered exactly as: 150

In addition, because the current constraint is lax, users may enter
arbitrary and large vaues for Credits (e.g. 999999999). However, in
practice, such large values are never needed.

Let's modify and update the `Credits` restrictions by:
* accepting up to 3 numeric digits only
* rejecting values with multiple digits beginning with `0`
* update `Credits#MESSAGE_CONSTRAINTS` to reflect the new range of
  acceptable values (0 - 999)

In addition, let's also update all affected unit tests that violates the
new credits constraint.

Run Details

1771 of 2131 relevant lines covered (83.11%)

0.83 hits per line

CS2113-AY1819S2-T09-1 / main / 352 / 1
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 352.1

CS2113-AY1819S2-T09-1 / main / 352 / 1 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 352.1

CS2113-AY1819S2-T09-1 / main / 352 / 1
92%
master: 92%

README BADGES
x