TykTechnologies / tyk / 6332 / 2

Ran 09 Mar 2019 11:43AM UTC

Files 108

Run time 7s

Badge

Embed ▾

Committed 09 Mar 2019 11:33AM UTC coverage: 62.298% (-0.01%) from 62.309%

Job # LATEST_GO=true

Build Type

push

travis-ci

Committed by

buger

Commit Message

res_handler_transform: make sure bodyData is available on XML errors (#2133)

For #2016.

I was able to reproduce using the instructions described in the ticket. The issue occurs at this point:

```go
	bodyData := make(map[string]interface{})
	switch tmeta.TemplateData.Input {
	case apidef.RequestXML:
		if len(body) == 0 {
			body = []byte("<_/>")
		}

		mxj.XmlCharsetReader = WrappedCharsetReader
		var err error

		bodyData, err := mxj.NewMapXml(body)
		if err != nil {
			logger.WithError(err).Error("Error unmarshalling XML")
		}
```

When `mxj.NewMapXml` returns an error, `bodyData` is not properly set and further references to it fail (like setting context vars using `bodyData["_tyk_context"] = ctxGetData(req)`).

This approach avoids replacing `bodyData`.

Run Details

10509 of 16869 relevant lines covered (62.3%)

0.69 hits per line

TykTechnologies / tyk / 6332 / 2

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6332.2 (LATEST_GO=true)

TykTechnologies / tyk / 6332 / 2

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6332.2 (LATEST_GO=true)

README BADGES
x