1
89%
master: 89%

Ran 07 Mar 2019 01:30AM UTC

Files 5

Run time 3s

Badge

Embed ▾

Committed 07 Mar 2019 01:29AM UTC coverage: 90.634% (+4.6%) from 86.008%

Job # GO111MODULE=on

Build Type

push

travis-ci

Committed by

kixelated

Commit Message

Add packetio interface for network buffering

We're not able to use `bytes.Buffer` because it would combine multiple
Writes into a single Read. `packetio.Buffer` provides a similar but is
designed to work with packets, avoiding this situation.

There are similar buffers implemented separarely in webrtc/srtp/ice/mux.
These used channels and were too slow to keep up with the read loop. I
wrote a benchmark for comparison:

```
name                   old time/op    new time/op     delta
BenchmarkBuffer14-8       859ns ± 5%      129ns ± 4%   -84.93%
BenchmarkBuffer140-8      832ns ± 4%      154ns ± 4%   -81.43%
BenchmarkBuffer1400-8     825ns ± 8%      351ns ± 4%   -57.49%

name                   old speed      new speed       delta
BenchmarkBuffer14-8    16.3MB/s ± 5%  107.8MB/s ± 3%  +561.08%
BenchmarkBuffer140-8    168MB/s ± 4%    904MB/s ± 4%  +436.70%
BenchmarkBuffer1400-8  1.70GB/s ± 8%   3.99GB/s ± 4%  +134.74%
```

Note that the channel implementation has no buffer. packetio.Buffer has
a configurable buffer size with `SetLimitCount` and `SetLimitSize`.

Run Details

329 of 363 relevant lines covered (90.63%)

20.91 hits per line

pions / transport / 40 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 40.1 (GO111MODULE=on)

pions / transport / 40 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 40.1 (GO111MODULE=on)

pions / transport / 40 / 1
89%
master: 89%

README BADGES
x