1
38%
master: 17%

Ran 23 Feb 2015 09:34PM UTC

Files 1

Run time 3s

Badge

Embed ▾

Committed 23 Feb 2015 09:30PM UTC coverage: 37.705%. Remained the same

Job # 1152.1

Build Type

push

travis-ci

Committed by

msimerson

Commit Message

rename net_utils.is_rfc1918 -> is_private_ip

RFC 1918 only specifies the 3 IPv4 private IP blocks. This function has evolved to also include loopback IPs and is likely to continue evolving to add other "Special IP allocations" (RFC 6890) such as the link local netblocks. This name encompasses all those uses.

* adds IPv6 link local to is_private_ip
    * fixes #850
* net_utils: wrap long lines (lint)
* net_utils, added is_local_ipv4, is_private_ipv4, & is_local_ipv6.
    * updated is_private_ip to use them
* adds additional test coverage
* considerably easier to maintain than one regex for ipv4 and one for ipv6
* no significant performance impact (0.05 second difference on 2 million iterations)
* side note: using ?: in /regex/.test(str) seems to make no performance different whatsoever (less than rounding error in testing).
* added docs for net_utils.is_local|private_ipv*

Run Details

23 of 61 relevant lines covered (37.7%)

0.38 hits per line

msimerson / Haraka / 1152 / 1
38%
master: 17%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1152.1

msimerson / Haraka / 1152 / 1 38% master: 17%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1152.1

msimerson / Haraka / 1152 / 1
38%
master: 17%

README BADGES
x