4
92%
master: 92%

Ran 04 Mar 2019 10:19PM UTC

Files 40

Run time 16s

Badge

Embed ▾

Committed 04 Mar 2019 10:19PM UTC coverage: 93.615% (+0.1%) from 93.475%

Job # 2.5

Build Type

push

travis-ci

Committed by

olleolleolle

Commit Message

Fix test order dependency in default_connection proxy test (#929)

* Fix the default_connection proxy test

The assignment to the mock connection:

`Faraday.default_connection = mock_connection`

was persisting throughout the tests.

If the random number generator is unlucky the following error occurs:

\#<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used.  rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for.

This commit fixes the issue by explicitly setting the default_connection
back to nil in an "after" block after the tests have run.

Subsequent calls to `default_connection` within the test suite then
behave as previously expected irrespective of the random test ordering.

Run Details

1642 of 1754 relevant lines covered (93.61%)

884.97 hits per line

lostisland / faraday / 2255 / 4
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2255.4 (2.5)

lostisland / faraday / 2255 / 4 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2255.4 (2.5)

lostisland / faraday / 2255 / 4
92%
master: 92%

README BADGES
x