apache / carbondata / 1544 / 1
76%
master: 76%

DEFAULT BRANCH: master
Ran
Files 1027
Run time 837min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.205% (-2.9%) from 79.121%
1544.1

push

jenkins

xuchuanyin 
[CARBONDATA-3107] Optimize error/exception coding for better debugging

Some error log in carbon is only a single line of conclusion message
(like "Dataload failed"), and when we look into codes may found that
is newly created exception without original exception, so more jobs
need to be done to find the root cause.

To better locate the root cause when carbon fails, this PR propose to
keep the original throwable for logging when wrapping it to another
exception, and also log stack trace alone with error message.

   Changes in this PR follows these rules: (`e` is an exception)

   | Code Sample | Problem | Suggest Modification |
   | --- | --- | --- |
   | `LOGGER.error(e);` | no stack trace(e is taken as message instead of throwable) | `LOGGER.error(e.getMessage(), e);` |
   | `LOGGER.error(e.getMessage());` | no stack trace | `LOGGER.error(e.getMessage(), e);` |
   | `catch ... throw new Exception("Error occur")` | useless message, no stack trace | `throw new Exception(e)` |
   | `catch ... throw new Exception(e.getMessage())` | no stack trace | `throw new Exception(e)` |
   | `catch ... throw new Exception(e.getMessage(), e)` | no need to call `getMessage()` | `throw new Exception(e)` |
   | `catch ... throw new Exception("Error occur: " + e.getMessage(), e)` | useless message | `throw new Exception(e)` |
   | `catch ... throw new Exception("DataLoad fail: " + e.getMessage())` | no stack trace | `throw new Exception("DataLoad fail: " + e.getMessage(), e)` |

   Some exceptions, such as MalformedCarbonCommandException,
   InterruptException, NumberFormatException, InvalidLoadOptionException
   and NoRetryException, do not have Constructor using `Throwable`,
   so this PR does not change it.

This closes #2878

60162 of 78948 relevant lines covered (76.2%)

0.99 hits per line

Source Files on job 1544.1