5
58%
master: 66%

Ran 21 Feb 2019 04:35PM UTC

Files 422

Run time 14min

Badge

Embed ▾

Committed 21 Feb 2019 03:07PM UTC coverage: 57.942% (-0.02%) from 57.962%

Job # COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS=""

Build Type

push

travis-ci

Committed by

nmathewson

Commit Message

kist: Don't write above the highwater outbuf mark

KIST works by computing how much should be allowed to write to the kernel for
a given socket, and then it writes that amount to the outbuf.

The problem is that it could be possible that the outbuf already has lots of
data in it from a previous scheduling round (because the kernel is full/busy
and Tor was not able to flush the outbuf yet). KIST ignores that the outbuf
has been filling (is above its "highwater") and writes more anyway. The end
result is that the outbuf length would exceed INT_MAX, hence causing an
assertion error and a corresponding "Bug()" message to get printed to the
logs.

This commit makes it for KIST to take into account the outbuf length when
computing the available space.

Bug found and patch by Rob Jansen.

Closes #29168. TROVE-2019-001.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Run Details

40285 of 69526 relevant lines covered (57.94%)

27593.37 hits per line

torproject / tor / 3900 / 5
58%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3900.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="")

torproject / tor / 3900 / 5 58% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3900.5 (COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="")

torproject / tor / 3900 / 5
58%
master: 66%

README BADGES
x