8
88%
master: 88%

Ran 20 Feb 2019 11:31PM UTC

Files 3

Run time 34min

Badge

Embed ▾

Committed 20 Feb 2019 11:16PM UTC coverage: 84.341% (+7.6%) from 76.731%

Job # 51.8

Build Type

push

travis-ci

Committed by

Jutho

Commit Message

Make convert(Real, ::HalfInteger) yield HalfInteger (#5)

As HalfInteger <: Real, there should be no reason to convert anything in
this situation. It happens because the convert method resorts to Float64
as an intermediate value.

To still get conversion to floats, we can just dispatch on AbstractFloat
instead. However, it should be better to convert the numerator to T
first and then divide, so that we would not use a potentially lower
precision intermediate value.

This solves the problem where calling sum on an vector of HalfIntegers
yields a floating point value, even though there is no reason to convert
in the summation:

julia> sum([HalfInteger(1//2), HalfInteger(3//2)])
2.0

This is because there is an implicit convert(::Real) in the Base.add_sum
function. With this patch the sum call correctly yields a HalfInteger.

It also updates the tests related to HalfInteger convert methods:

 - Make sure that the convert tests also check types
 - Add a few tests for converting out of HalfInteger

Run Details

307 of 364 relevant lines covered (84.34%)

21176828.85 hits per line

Jutho / WignerSymbols.jl / 51 / 8
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 51.8

Jutho / WignerSymbols.jl / 51 / 8 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 51.8

Jutho / WignerSymbols.jl / 51 / 8
88%
master: 88%

README BADGES
x