l0rdn1kk0n / wicket-bootstrap / 1837 / 1
47%
master: 57%

LAST BUILD BRANCH: wicket-8.x-bootstrap-4.x
DEFAULT BRANCH: master
Ran
Files 460
Run time 49s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 45.591% (+7.4%) from 38.205%
1837.1

push

travis-ci

martin-g 
Feature/707 font awesome 5 (#790)

I'm somewhat unsure what would be the best way to implement font-awesome-5.x.

This might eventually fix #707.

First thing, changing the version from 4.7 to 5.7 is a breaking change, as (at least some) of the icons have different names or are not available anymore.

Further, font-awesome now has 4 different styles of icons, 3 of which can be used in wicket-bootstrap.

* style `solid`: All icons are free and can be used in the project. To be used with `fas` (or `fa`)
* style `regular`: Only some of those icons are free, many are not. To be used with `far`
* style `brand`: all free. To be used with `fab`
* style `light` all of which are not free - and thus don't need to be further discussed here.

The icons of style `brand` have distinctive names and are not an issue. The icons that are freely available in style `regular` use the same name as those in `solid`.

I have separated the three different free icon styles within FontAwesomeIconTypeBuilder. One enum each `FontAwesomeSolid`, `FontAwesomeRegular` and `FontAwesomeBrand` (all implementing `FontAwesomeGraphic` which is now an interface) define each icon. So as with the additional attributes of the icons (spin, fixedWith etc.), the user has full freedom on how to use which style in which variant.

For the pre-built instances of `FontAwesomeIconType` I see two general approaches (with sub-options) how we can handle those in wicket-bootstrap:

* Aproach 1: Every style is implemented in it's own instance of `FontAwesomeIconType`. We can use tags to distinguish the style (between regular and solid, no name clash for brands)
  * Option 1.1: Use the tag `_r`/`_s` where we have both a variant of style solid and regular (e.g. `address_book_s` and `address_book_r`). Where we only have a solid variant right now, we don't apply the tag `s`. the icon `adjust` currently is only (freely) available as solid. If in the future it will also have a regular variant ... (continued)

5362 of 11761 relevant lines covered (45.59%)

31.18 hits per line

Source Files on job 1837.1