3
100%
master: 100%

Ran 13 Feb 2019 07:41PM UTC

Files 29

Run time 29min

Badge

Embed ▾

Committed 13 Feb 2019 07:30PM UTC coverage: 98.832% (-0.02%) from 98.854%

Job # 1393.3

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Use binary_type in MongoDBStore.__getitem__ for Python 2 only (#401)

* Drop binary_type cast in MongoDBStore.__getitem__

* Coerce PyMongo values to `binary_type` on Python 2

On both Python 2 and Python 3, PyMongo converts `binary_type` (i.e.
`bytes`) to BSON type 5 (Binary data) with subtype 0 to store in the
MongoDB instance. When reading that data back out, PyMongo handles BSON
type 5 (Binary data) with subtype 0 differently depending on the Python
version.

On Python 2, it creates a `bson.Binary` instance with the data. Normally
we would coerce this to a `bytes` object using `ensure_bytes`. However
that fails as `bson.Binary` is a subclass of `bytes`. So instead we
explicitly force it to `bytes` (i.e.  `binary_type`). On Python 3,
PyMongo automatically converts the data to `bytes`. Thus we don't need
to do anything there.

ref: http://api.mongodb.com/python/current/python3.html#id3
ref: http://api.mongodb.com/python/current/api/bson/binary.html#bson.binary.Binary

Run Details

8544 of 8645 relevant lines covered (98.83%)

0.99 hits per line

zarr-developers / zarr / 1393 / 3
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1393.3

zarr-developers / zarr / 1393 / 3 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1393.3

zarr-developers / zarr / 1393 / 3
100%
master: 100%

README BADGES
x