2
87%
master: 86%

Ran 11 Feb 2019 08:17PM UTC

Files 188

Run time 27min

Badge

Embed ▾

Committed 11 Feb 2019 07:24PM UTC coverage: 86.431% (-0.2%) from 86.602%

Job # 651.2

Build Type

Pull #74

travis-ci

Committed by

web-flow

Commit Message

Removed incorrect use of InputStream.available() in ArArchiveInputStream

The original code appears to be checking for end-of-file
using the InputStream.available() method.

This however, misunderstands the InputStream API. The available()
method only returns an estimate, and cannot be used
to check for the remaining bytes in the file. From the documentation:

> Returns an estimate of the number of bytes that can be read (or
> skipped over) from this input stream without blocking by the next
> invocation of a method for this input stream. The next invocation
> might be the same thread or another thread.  A single read or skip of this
> many bytes will not block, but may read or skip fewer bytes.
> Note that while some implementations of InputStream will return
> the total number of bytes in the stream, many will not.  It is
> never correct to use the return value of this method to allocate
> a buffer intended to hold all data in this stream.

This patch includes a unit test that demonstrates the bug and
verifies the fix.

Pull Request Pull Request #74: Removed incorrect use of InputStream.available() in ArArchiveInputStream

Coverage Stats

11427 of 13221 relevant lines covered (86.43%)

0.86 hits per line

apache / commons-compress / 651 / 2
87%
master: 86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 651.2

apache / commons-compress / 651 / 2 87% master: 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 651.2

apache / commons-compress / 651 / 2
87%
master: 86%

README BADGES
x