9
91%
master: 91%

Ran 06 Feb 2019 10:46PM UTC

Files 44

Run time 5s

Badge

Embed ▾

Committed 06 Feb 2019 10:27PM UTC coverage: 90.538% (-0.4%) from 90.943%

Job # TARGET=coverage SHARD_VERSION=2.1 AVRO_SCHEMA=3.0.1

Build Type

push

travis-ci

Committed by

Totktonada

Commit Message

Give an empty multihead connection as null

This commit changes behaviour in the following cases:

1. When a union variant to which a connected object belongs is not appear
   in a query, the library returns box.NULL w/o any wrappers.

2. When no connected object is found, the library returns box.NULL as
   well even if all-nulls check before fails (typically because of
   disable_dangling_check option, but also it is possible because of
   using different source fields across multihead connection variants).

The first case is tested with to_avro_multihead.test.lua. The latter one
does not tested.

In these cases we could receive `{"collection_name": null}` as a result
instead of just `null`. Only `null` is valid result for a avro-schema
union.

Both variant however are valid by our avro-schema generated for a query,
because a multi-head connection represented as an object with nullable
fields. There is a reason for that, see the comment for the
union_to_avro() function in graphql/query_to_avro.lua.

Fixes #253.

Run Details

5540 of 6119 relevant lines covered (90.54%)

18437.31 hits per line

tarantool / graphql / 691 / 9
91%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 691.9 (TARGET=coverage SHARD_VERSION=2.1 AVRO_SCHEMA=3.0.1)

tarantool / graphql / 691 / 9 91% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 691.9 (TARGET=coverage SHARD_VERSION=2.1 AVRO_SCHEMA=3.0.1)

tarantool / graphql / 691 / 9
91%
master: 91%

README BADGES
x