• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zulip / zulip-mobile / 8158 / 1
65%
master: 65%

Build:
DEFAULT BRANCH: master
Ran 01 Feb 2019 10:49PM UTC
Files 364
Run time 45s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Feb 2019 10:42PM UTC coverage: 65.46% (-0.05%) from 65.511%
COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv

push

travis-ci

gnprice
nullObjects: Cut nullFunction.

The main way we used to use this was to pass as callbacks like
`onPress` where we didn't have anything we actually wanted to run in
the callback.

But the conventional way that React Native upstream components accept
for indicating that is to simply pass `undefined`.  We've adopted the
same convention in our many components that take a callback prop which
they pass on to some upstream component, and then it's been natural to
do the same in the components where we accept a callback we'll call
ourselves.

This `undefined` convention has the advantage of transparency -- any
JavaScript code can easily inspect the value (simply test it for
truthiness) and determine that it isn't a function that's going to
actually do anything when called, potentially saving some effort.  It
also greatly simplifies invoking an interface that takes a number of
optional callbacks -- it's much simpler and clearer to simply omit
those properties entirely, rather than mention each of them only to
pass a no-op value.

In the preceding few commits we eliminated the handful of remaining
references to this value (the majority of them in code that we already
never invoked); now remove it.

1395 of 2923 branches covered (47.72%)

Branch coverage included in aggregate %.

4825 of 6579 relevant lines covered (73.34%)

16.67 hits per line

Source Files on job 8158.1 (COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv)
  • Tree
  • List 0
  • Changed 4
  • Source Changed 4
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 24437
  • Travis Job 8158.1
  • 3bc39ec0 on github
  • Prev Job for COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv on master (#8154.1)
  • Next Job for COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv on master (#8161.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc