• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

apache / bookkeeper / 347 / 1
72%
master: 72%

Build:
DEFAULT BRANCH: master
Ran 01 Feb 2019 02:56PM UTC
Files 494
Run time 32s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Feb 2019 02:56PM UTC coverage: 72.349% (-0.01%) from 72.36%
347.1

push

jenkins

Jia Zhai
Ignore usage of localNode in PlacementPolicy.


Descriptions of the changes in this PR:

'ignoreLocalNodeInPlacementPolicy' specifies whether to ignore localnode
in the internal logic of placement policy. If it is not possible or useful
to use Bookkeeper client node's (or AutoReplicator) rack/region info. for
placement policy then it is better to ignore localnode instead of false
alarming with error/warn log lines and metrics.

It is not valid to expect rack mapping information to be available for Bookkeeper
client and ReplicationWorker nodes. So if rackmapping info. is not available
then it is better to ignore creation of BookieNode by resolving rack information
for the client localnode. Otherwise it would log unnecessary warn/error log lines
and rack resolution failure metrics.

Reviewers: Sijie Guo <sijie@apache.org>, Jia Zhai <zhaijia@apache.org>, Enrico Olivelli <eolivelli@gmail.com>

This closes #1917 from reddycharan/ignorelocalnodeinplacementpolicy

26353 of 36425 relevant lines covered (72.35%)

0.72 hits per line

Source Files on job 347.1
  • Tree
  • List 0
  • Changed 22
  • Source Changed 0
  • Coverage Changed 22
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 347
  • d8b894f3 on github
  • Prev Job for on master (#346.1)
  • Next Job for on master (#348.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc